[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs

[Shaurya Gupta via Phabricator via cfe-commits]

SureYeaah added a comment.

In D64717#1585512 <https://reviews.llvm.org/D64717#1585512>, @sammccall wrote:

> Are you sure we want to disable extraction here, rather than just do the extraction at a higher level?
>
> E.g. if `bar(1,2,3, f[[o]]o(4,5));` seems like it should extract the call too `foo(4,5)`, not fail to trigger entirely.


Selecting `f[[o]]o(4,5)` will just extract the `foo` which would be a `DeclRefExpr`. We want to extract the `CallExpr` for which we would need to select the brackets as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64717/new/

https://reviews.llvm.org/D64717