[PATCH] D64717: [Clangd] Fixed ExtractVariable for MemberExprs and Assignment Exprs
Kadir Cetinkaya via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 15 05:54:50 PDT 2019
kadircet added inline comments.
================
Comment at: clang-tools-extra/clangd/unittests/TweakTests.cpp:302
void f() {
- int a = 5 + [[4 ^* ^xyz^()]];
+ int a = 5 + [[4 * [[xyz()]]]];
// multivariable initialization
----------------
kadircet wrote:
> how come these changes part of that patch?
>
> is it possible that this tweak was changed to not trigger on empty selections, but tests were not updated? If that's the case could you please send these on a different patch and rebase this patch on that one?
> how come these changes part of that patch?
how come these changes *are* part of that patch?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64717/new/
https://reviews.llvm.org/D64717
More information about the cfe-commits
mailing list