[PATCH] D61989: [clang-tidy] enable modernize-concat-nested-namespaces on header files
Alexander Kornienko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Jul 15 03:13:30 PDT 2019
alexfh added inline comments.
================
Comment at: clang-tools-extra/test/clang-tidy/modernize-concat-nested-namespaces.h:1
+#pragma once
+
----------------
Please put the header under Inputs/<check-name>/ directory to keep the tests directory a bit tidier. The header can then be renamed to something shorter, btw.
================
Comment at: clang-tools-extra/test/clang-tidy/modernize-concat-nested-namespaces.h:1
+#pragma once
+
----------------
alexfh wrote:
> Please put the header under Inputs/<check-name>/ directory to keep the tests directory a bit tidier. The header can then be renamed to something shorter, btw.
Is it important to use `#pragma once` in this file? Can we use regular include guards instead?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D61989/new/
https://reviews.llvm.org/D61989
More information about the cfe-commits
mailing list