[PATCH] D64628: [CrossTU] Test change only: improve ctu-main.c

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 15 02:56:35 PDT 2019


martong added a comment.

In D64628#1584969 <https://reviews.llvm.org/D64628#1584969>, @balazske wrote:

> The mentioned commit has a test that reproduces the same problem, so this revision is not needed (abandon it?).


I think we should have this change, because it tests also if we can import the "extern implicit" function properly. Plus the bug visitor is exercised when the AST is merged.
So, even if the mentioned commit has a similar test I think with these changes we can achieve higher coverage and can prevent CTU related regression.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64628/new/

https://reviews.llvm.org/D64628





More information about the cfe-commits mailing list