[PATCH] D64271: [analyzer] Don't track the right hand side of the last store for conditions

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Jul 14 10:51:31 PDT 2019


Szelethus added a comment.

In D64271#1576872 <https://reviews.llvm.org/D64271#1576872>, @NoQ wrote:

> I'd rather not abandon this patch, because it looks like a strict improvement over the lack of condition tracking, and it might as well still be an improvement over "zealous" condition tracking, as my counterexample is fairly artificial. It indicates that a slightly more sophisticated algorithm is necessary (i'm not sure if it's single-pass or even linear). But i'll be perfectly happy with simply adding it as a FIXME test.


My other patches actually deal with this far more nicely. D64272 <https://reviews.llvm.org/D64272> + D64232 <https://reviews.llvm.org/D64232> combined almost achieve the same thing, but I'm running analyses to find gather some real world experience.
.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64271/new/

https://reviews.llvm.org/D64271





More information about the cfe-commits mailing list