[PATCH] D64600: [ObjC] Add an attribute that "clamps" signed char BOOLs to {0,1}

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:3279
+def ObjCClampingBool : TypeAttr {
+  let Spellings = [Clang<"objc_clamping_bool">];
+  let Subjects = SubjectList<[TypedefName]>;
----------------
erik.pilkington wrote:
> aaron.ballman wrote:
> > Is there a desire for similar functionality for C's `_Bool` datatype, or other, custom datatypes (perhaps `BOOL` from the Win32 APIs)? It seems like this attribute could be generalized to apply to any typedef to an integral type.
> Sure, I guess there isn't anything Objective-C specific about this. The new patches renames it to `clamping_integral_bool` (and permits it on any integral type).
Given that "clamping" isn't exactly what's going on -- since `-1` becomes `1`, not `0` -- is there another word we can use here?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64600/new/

https://reviews.llvm.org/D64600