[PATCH] D64666: [Sema] Enable -Wimplicit-float-conversion for integral to floating point precision loss

[Ziang Wan via Phabricator via cfe-commits]

ziangwan marked 2 inline comments as done.
ziangwan added inline comments.


================
Comment at: clang/test/Sema/implicit-float-conversion.c:29
+  double e = 0.0;
+  double f = i + e;
+}
----------------
etalvala wrote:
> should this also test the case of:
> `
> long g = 222222222222L;
> long h = g + a;
> `
> or is that unlikely to fail if the assignment-to-float variant succeeds?
> 
I feel like your case is covered in the testReturn() function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64666/new/

https://reviews.llvm.org/D64666