[PATCH] D64656: Ensure placeholder instruction for cleanup is created

Fri Jul 12 15:05:13 PDT 2019

oydale marked an inline comment as done.
oydale added inline comments.

================
Comment at: clang/test/CodeGenCXX/pr40771-ctad-with-lambda-copy-capture.cpp:2
+// RUN: %clang_cc1 -emit-obj --std=c++17 -fcxx-exceptions -fexceptions -O1 %s
+// CHECK no crash
+
----------------
rjmccall wrote:
> oydale wrote:
> > lebedev.ri wrote:
> > > Either add missing `:` or please write better comment :)
> > I'm not sure what else that comment would contain. I want the test to verify that clang does not crash given the provided input. 
> We have a testing tool called FileCheck which is used to pattern-match compiler output, and it uses a lot of lines that look like `CHECK: blah`, so the all-caps CHECK makes people think that it's supposed to be a FileCheck line.  Please just write the comment normally, like "PR4771: check that this doesn't crash."
> 
> Was this crash specific to optimization being enabled?
I'll change it to a normal-looking comment.

Yes, for a release build the crash does not happen unless -O1 or greater is specified.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64656/new/

https://reviews.llvm.org/D64656