[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 12 12:54:51 PDT 2019


sammccall added inline comments.


================
Comment at: clang-tools-extra/trunk/clangd/unittests/TypeHierarchyTests.cpp:629
+      AST, Source.point(), /*ResolveLevels=*/1,
+      TypeHierarchyDirection::Children, Index.get(), "/clangd-test/TestTU.cpp");
+  ASSERT_TRUE(bool(Result));
----------------
yes, this should be `testPath(TU.Filename)`

(TU.Filename is always unix-style relative path, testPath() makes it an OS-style absolute path)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64308/new/

https://reviews.llvm.org/D64308





More information about the cfe-commits mailing list