[PATCH] D64656: Ensure placeholder instruction for cleanup is created

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 12 12:35:12 PDT 2019


rjmccall added inline comments.


================
Comment at: clang/lib/CodeGen/CGExprAgg.cpp:1627
+        llvm::Constant::getNullValue(CGF.Int8PtrTy),
+        CharUnits::One()); // placeholder
+
----------------
Please declare a lambda to add a cleanup which implicitly creates this dominator and then just call it in the places that currently directly do `cleanups.push_back`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64656/new/

https://reviews.llvm.org/D64656





More information about the cfe-commits mailing list