[PATCH] D64537: [WebAssembly] Implement thread-local storage (local-exec model)

Guanzhong Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 12 11:04:40 PDT 2019


quantum marked 4 inline comments as done.
quantum added inline comments.


================
Comment at: lld/wasm/Writer.cpp:629
+  // Merge .tbss into .tdata so that they share the same offsets.
+  if (name.startswith(".tbss."))
+    return ".tdata";
----------------
sbc100 wrote:
> Maybe write this as a single conditional so its clear even without this comment?
Changed in latest diff.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64537/new/

https://reviews.llvm.org/D64537





More information about the cfe-commits mailing list