[PATCH] D64400: [OpenCL][PR42390] Deduce addr space for templ specialization

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 12 08:12:33 PDT 2019


Anastasia added a comment.

In D64400#1582142 <https://reviews.llvm.org/D64400#1582142>, @rjmccall wrote:

> There are some code paths that I think are common between the parser and template instantiation, like `BuildPointerType` and `BuildReferenceType`, but if you want to do context-sensitive inference that might not be good enough.


Actually for pointee types we don't need context-sensitive inference. This is mainly for regular types, but in templates we have much less use cases and I haven't caught any issue with the current implementation although we still keep some inference logic for dependent types. But it's simple enough. Potentially we can assess the corner cases as we go along and discover them.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64400/new/

https://reviews.llvm.org/D64400





More information about the cfe-commits mailing list