[PATCH] D64308: [clangd] Implement typeHierarchy/resolve for subtypes

[Nathan Ridge via Phabricator via cfe-commits]

nridge marked an inline comment as done.
nridge added inline comments.


================
Comment at: clang-tools-extra/clangd/test/type-hierarchy.test:1
 # RUN: clangd -lit-test < %s | FileCheck -strict-whitespace %s
 {"jsonrpc":"2.0","id":0,"method":"initialize","params":{"processId":123,"rootPath":"clangd","capabilities":{},"trace":"off"}}
----------------
sammccall wrote:
> Please add a unit test to TypeHierarchyTests.
> 
> I'm on the fence about having a lit test: it's a new LSP method, though the binding is pretty simple.
> But features that are **only** covered by lit tests are too painful to maintain.
As I've already written the lit test, I think there's little harm in keeping it.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64308/new/

https://reviews.llvm.org/D64308