[PATCH] D64146: [ConstExprPreter][WIP] Initial patch for the constexpr interpreter

[JF Bastien via Phabricator via cfe-commits]

jfb added inline comments.


================
Comment at: clang/lib/AST/ExprVM/Compiler.cpp:85
+                                                /* isArray */ false,
+                                                /* isGlobal */ false);
+      ParamDescriptors.insert({ParamOffset, std::move(Desc)});
----------------
Usually the style used is `/*isMutable=*/true`


================
Comment at: clang/lib/AST/ExprVM/Compiler.h:69
+public:
+  /// Creates a compiler for a funciton.
+  Compiler(Context &Ctx, Program &P, const FunctionDecl *F);
----------------
"function"


================
Comment at: clang/lib/AST/ExprVM/Compiler.h:125
+    /// Size of the local, in bytes.
+    unsigned Size;
+  };
----------------
`ByteSize` since it's the size in bytes :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64146/new/

https://reviews.llvm.org/D64146