[PATCH] D63975: Warn when ScopeDepthOrObjCQuals overflows

Mark de Wever via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 11 14:48:29 PDT 2019


Mordante marked an inline comment as done.
Mordante added inline comments.


================
Comment at: clang/lib/Parse/ParseDecl.cpp:6587
+        return;
+      }
+
----------------
rjmccall wrote:
> Comment indentation.
> 
> Should we do this when starting to parse a function prototype instead of when parsing a parameter?
Thanks I noticed I forgot to change the tabs to spaces.

I looked at your suggestion to move the code, but I think this is the proper place. Now it also validates whether lambdas exceed the limit, else we need to check at two places.
I'll also add a unit test to test for the lambda.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63975/new/

https://reviews.llvm.org/D63975





More information about the cfe-commits mailing list