[PATCH] D64582: cmake: Fix install of libclang_shared.so when LLVM_INSTALL_TOOLCHAIN_ONLY=ON

Tom Stellard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 11 12:26:24 PDT 2019


tstellar created this revision.
tstellar added reviewers: beanz, smeenai.
Herald added a subscriber: mgorny.
Herald added a project: clang.
tstellar added a parent revision: D64580: cmake: Add INSTALL_WITH_TOOLCHAIN option to add_*_library macros.

If CLANG_LINK_CLANG_DYLIB is also enabled, then this library needs to be
installed.

Fixes PR42575.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D64582

Files:
  clang/tools/clang-shlib/CMakeLists.txt


Index: clang/tools/clang-shlib/CMakeLists.txt
===================================================================
--- clang/tools/clang-shlib/CMakeLists.txt
+++ clang/tools/clang-shlib/CMakeLists.txt
@@ -11,8 +11,13 @@
   list(APPEND _DEPS $<TARGET_PROPERTY:${lib},LINK_LIBRARIES>)
 endforeach ()
 
+if (CLANG_LINK_CLANG_DYLIB)
+  set(INSTALL_WITH_TOOLCHAIN INSTALL_WITH_TOOLCHAIN)
+endif()
+
 add_clang_library(clang_shared
                   SHARED
+                  ${INSTALL_WITH_TOOLCHAIN}
                   clang-shlib.cpp
                   ${_OBJECTS}
                   LINK_LIBS


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D64582.209295.patch
Type: text/x-patch
Size: 591 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20190711/4f5b44b1/attachment.bin>


More information about the cfe-commits mailing list