[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

[Shoaib Meenai via Phabricator via cfe-commits]

smeenai added a comment.

In D64579#1581194 <https://reviews.llvm.org/D64579#1581194>, @smeenai wrote:

> In D64579#1581172 <https://reviews.llvm.org/D64579#1581172>, @phosek wrote:
>
> > While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most distributions, so this LGTM. Maybe leave a TODO that this should be revisited after we bump minimum CMake requirement to 3.12 or newer?
>
>
> FWIW, CMake 3.4.3 was released Jan 25 2016 (https://cmake.org/pipermail/cmake/2016-January/062616.html) and we started requiring it on May 31 2016 (https://reviews.llvm.org/D20822), so we do have precedence for requiring a pretty recent CMake version. I guess we should figure out what other compelling reasons we'd have for moving to that version though.


I'll wait a bit in case @beanz has any thoughts and then commit this with the added TODO.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64579/new/

https://reviews.llvm.org/D64579