[PATCH] D64579: [clang-shlib] Fix clang-shlib for PRIVATE dependencies

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 11 12:10:02 PDT 2019


phosek accepted this revision.
phosek added a comment.
This revision is now accepted and ready to land.

While upgrading to newer CMake would be nice, I think it's unlikely that we could move all the way to 3.12 since that version was only released a year ago and still isn't available in most distributions, so this LGTM. Maybe leave a TODO that this should be revisited after we bump minimum CMake requirement to 3.12 or newer?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64579/new/

https://reviews.llvm.org/D64579





More information about the cfe-commits mailing list