[PATCH] D64565: [clangd] Don't run the prepare for tweaks that are disabled.
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 11 08:10:53 PDT 2019
hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/ClangdServer.h:136
- /// Returns true if the StringRef is a tweak that should be enabled
- std::function<bool(llvm::StringRef)> TweakFilter = [](llvm::StringRef TweakToSearch) {return true;};
+ /// Returns true if the StringRef is a tweak ID that should be enabled.
+ std::function<bool(const Tweak &)> TweakFilter = [](const Tweak &T) {
----------------
ilya-biryukov wrote:
> NIT: the comment mentions `StringRef`, but function accepts a `Tweak` now.
> Maybe update the comment?
good catch, thanks!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64565/new/
https://reviews.llvm.org/D64565
More information about the cfe-commits
mailing list