[PATCH] D64556: [clangd] Fix an assertion crash in "ExtractVariable" tweak

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 11 04:16:59 PDT 2019


hokein marked an inline comment as done.
hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/Selection.cpp:367
   }
-  return nullptr;
 }
----------------
sorry, the previous patch rL365751 didn't fix the crash, and I re-read the code more thoroughly, I think we will never hit this point, need you confirmation, @sammccall.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64556/new/

https://reviews.llvm.org/D64556





More information about the cfe-commits mailing list