[PATCH] D64364: [HIP] Add GPU arch gfx1010, gfx1011, and gfx1012

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 10 15:42:25 PDT 2019


tra accepted this revision.
tra added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntimeNVPTX.cpp:4973-4992
   case CudaArch::GFX600:
   case CudaArch::GFX601:
   case CudaArch::GFX700:
   case CudaArch::GFX701:
   case CudaArch::GFX702:
   case CudaArch::GFX703:
   case CudaArch::GFX704:
----------------
Just a side note: 
I wonder if we need these at all -- we'll end up failing with misleading "Unexpected NVPTX target without ptx feature" assertion. We may just remove all non-SM_xx arch cases and replace them with default: calling llvm_unreachable(). Perhaps in a separate patch.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64364/new/

https://reviews.llvm.org/D64364





More information about the cfe-commits mailing list