[PATCH] D61749: [clang-tidy] initial version of readability-const-method

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri resigned from this revision.
lebedev.ri added a comment.

Sorry, it does not appear that i'm being useful in this review.



================
Comment at: clang-tools-extra/clang-tidy/readability/StaticMethodCheck.cpp:89-101
+          isDefinition(), isUserProvided(), unless(isExpansionInSystemHeader()),
+          unless(isVirtual()), unless(isStatic()), unless(hasTrivialBody()),
+          unless(isOverloadedOperator()), unless(isConstructor()),
+          unless(isDestructor()), unless(isConversionOperator()),
+          unless(isTemplate()), unless(isDependentContext()),
+          unless(ofClass(
+              anyOf(isLambda(),
----------------
I'm pretty sure you can do
```
unless(anyOf(isExpansionInSystemHeader(), isVirtual(), ...))
```


================
Comment at: clang-tools-extra/test/clang-tidy/readability-static-method.cpp:103
+}
+
+template <class Base>
----------------
Is there a test where a lambda (variant with and without capturing this, either explicitly, or implicitly)
is within a non-static class function?



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D61749/new/

https://reviews.llvm.org/D61749