[PATCH] D64504: Various minor tweaks to CLCompatOptions.td

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 10 13:56:20 PDT 2019


rnk added inline comments.


================
Comment at: clang/include/clang/Driver/CLCompatOptions.td:102
 def _SLASH_Gy_ : CLFlag<"Gy-">,
   HelpText<"Don't put each function in its own section (default)">,
   Alias<fno_function_sections>;
----------------
ditto


================
Comment at: clang/include/clang/Driver/CLCompatOptions.td:107
 def _SLASH_Gw_ : CLFlag<"Gw-">,
-  HelpText<"Don't put each data item in its own section">,
+  HelpText<"Don't put each data item in its own section (default)">,
   Alias<fno_data_sections>;
----------------
Standardize on uncontracted "Do not"?


================
Comment at: clang/include/clang/Driver/CLCompatOptions.td:250
 def _SLASH_Zi : CLFlag<"Zi">, Alias<_SLASH_Z7>,
-  HelpText<"Alias for /Z7. Does not produce PDBs.">;
+  HelpText<"Like /Z7">;
 def _SLASH_Zp : CLJoined<"Zp">,
----------------
I liked "Alias for /Z7". The note that it doesn't produce type server PDBs like /Zi would is interesting, but perhaps too much info for --help text.


================
Comment at: clang/include/clang/Driver/CLCompatOptions.td:294
 def _SLASH_GX : CLFlag<"GX">,
-  HelpText<"Enable exception handling">;
+  HelpText<"Deprecated (like /EHsc)">;
 def _SLASH_GX_ : CLFlag<"GX-">,
----------------
"Deprecated in favor of /EHsc"? or "(use /EHsc instead)"?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64504/new/

https://reviews.llvm.org/D64504





More information about the cfe-commits mailing list