[PATCH] D63835: [Syntax] Add nodes for most common statements

[Ilya Biryukov via Phabricator via cfe-commits]

ilya-biryukov added inline comments.


================
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:185
+/// if (cond) <then-statement> else <else-statement>
+class IfStatement final : public Statement {
+public:
----------------
sammccall wrote:
> I guess the missing cond here (and similar below) are due to complexities around the variable declaring variants?
> 
> Warrants a FIXME I think
Yes. Added a FIXME


================
Comment at: clang/include/clang/Tooling/Syntax/Nodes.h:265
+/// return <expr>;
+class ReturnStatement final : public Statement {
+public:
----------------
sammccall wrote:
> (any reason we can't already have the expr here?)
Added a getter for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63835/new/

https://reviews.llvm.org/D63835