[PATCH] D64256: Teach some warnings to respect gsl::Pointer and gsl::Owner attributes
Dmitri Gribenko via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 10 01:28:48 PDT 2019
gribozavr accepted this revision.
gribozavr added a comment.
This revision is now accepted and ready to land.
I'm not an expert in SemaInit code, but this change LGTM.
================
Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:8
+
+struct OwnerWithConv;
+
----------------
Not needed anymore.
================
Comment at: clang/test/Sema/warn-lifetime-analysis-nocfg.cpp:25
+
+struct [[gsl::Owner(int)]] OwnerWithConv {
+ OwnerWithConv();
----------------
Would be nice if the second pair of types had clearly related names, like the first pair (MyOwner/MyPointer).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64256/new/
https://reviews.llvm.org/D64256
More information about the cfe-commits
mailing list