[PATCH] D64257: [clangd] Added highlighting for class and enum types

[Haojian Wu via Phabricator via cfe-commits]

hokein added a comment.

In D64257#1577347 <https://reviews.llvm.org/D64257#1577347>, @nridge wrote:

> are you testing these patches against a client-side implementation of semantic highlighting? If so, which one?


Looks like Theia is the only LSP client supporting the semantic highlighting proposal, we use it to verify the behavior.

And we also have a hidden tweak (run clangd with `-hidden-feature`) to annotate all the highlighting tokens, we use it to verify whether the token is being highlighted in a correct TextMate scope (it is triggered via the codeAction in VSCode).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64257/new/

https://reviews.llvm.org/D64257