[PATCH] D64374: [analyzer] CastValueChecker: Model casts

Artem Dergachev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 16:04:55 PDT 2019


NoQ added a comment.

Mmm. Ok, am i understanding correctly that this was crashing because you bound a `0 (Loc)` to a prvalue expression of type `unique_ptr`? Yeah, right, don't do that :)

> used like 20 times in the LLVM codebase

That doesn't sound like it's high on our list. That's not too many times. Probably very few false positives come out of it. Also modeling smart pointers is much harder than modeling regular pointers. We could add some modeling into `SmartPtrChecker`, but that'd require actually developing that checker :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64374/new/

https://reviews.llvm.org/D64374





More information about the cfe-commits mailing list