[PATCH] D64448: gsl::Owner/gsl::Pointer: Add implicit annotations for some std types

Gábor Horváth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 15:24:43 PDT 2019


xazax.hun added a comment.

In D64448#1577109 <https://reviews.llvm.org/D64448#1577109>, @gribozavr wrote:

> > The tests are currently here
> >  I think due to their dependency on a standard library, they are not a good fit for clang/test/. Where else could I put them?
>
> Make some mocks that reproduce the salient parts of different libraries, the coding patterns they use, and check them into clang/test.


Those are already there in `clang/test/SemaCXX/attr-gsl-owner-pointer.cpp`. I was thinking about adding the corresponding tests to libc++ as well so we have better chances to get some notifications if a new language feature/implementation trick is introduced.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64448/new/

https://reviews.llvm.org/D64448





More information about the cfe-commits mailing list