[PATCH] D63663: [clang-doc] Add html links to references

Diego Astiazarán via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 13:15:49 PDT 2019


DiegoAstiazaran added inline comments.


================
Comment at: clang-tools-extra/clang-doc/Serialize.cpp:567
+      ParentI->Namespace = llvm::SmallVector<Reference, 4>(
+          Enum.Namespace.begin() + 1, Enum.Namespace.end());
+      ParentI->Path = getInfoOutputFile(OutDirectory, ParentI->Namespace);
----------------
juliehockett wrote:
> nit: use `++Enum.Namespace.begin()`
++ operator cannot be used in that expression because it's not assignable.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63663/new/

https://reviews.llvm.org/D63663





More information about the cfe-commits mailing list