[PATCH] D63894: [CXX] Exercise all paths through these tests

[Paul Robinson via Phabricator via cfe-commits]

probinson marked an inline comment as done.
probinson added inline comments.


================
Comment at: clang/test/SemaCXX/linkage2.cpp:3
+// RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args %s -std=gnu++98
 // RUN: %clang_cc1 -fsyntax-only -verify -Wno-c++11-extensions -Wno-local-type-template-args -fmodules %s
 
----------------
rsmith wrote:
> Should this one be run in C++98 mode too? (The use of `-Wno-c++11-extensions` suggests to me that C++98 was expected.)
I don't think so; `-Wno-c++11-extensions` will not suppress diagnostics about GNU extensions.  I think GNU++98 is what's wanted here (and is the old default dialect).


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63894/new/

https://reviews.llvm.org/D63894