[PATCH] D64383: build: use multiple `install` rather than building up a list
Shoaib Meenai via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 9 12:22:03 PDT 2019
smeenai added inline comments.
================
Comment at: src/CMakeLists.txt:440
+ endif()
+ if (LIBCXX_INSTALL_STATIC_LIBRARY)
+ install(TARGETS cxx_static
----------------
Super nit: you don't have a newline here but do have a newline before the LIBCXX_INSTALL_EXPERIMENTAL_LIBRARY conditional. (I don't have a preference for newline vs. no newline; the inconsistency is just mildly noticeable).
Repository:
rCXX libc++
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D64383/new/
https://reviews.llvm.org/D64383
More information about the cfe-commits
mailing list