[PATCH] D64301: Use `ln -n` to prevent forming a symlink cycle, instead of rm'ing the source

[Alexandre Ganea via Phabricator via cfe-commits]

aganea added a comment.

In D64301#1576615 <https://reviews.llvm.org/D64301#1576615>, @aganea wrote:

> In D64301#1574304 <https://reviews.llvm.org/D64301#1574304>, @rnk wrote:
>
> > I think @zturner wanted to teach lit to completely remove the Output/ directory for every test so we don't have to deal with stale files from previous tests hanging around. I remember objecting that we can't do that on startup since it's slow and not parallelized. However, I think we could probably add it as an early step to TestRunner.executeShTest so we don't have to add these extra 'rm' commands anymore.
>
>
> Just a reminder, the `DeleteFile` API, and thus `rm` on Windows are async. There's no guarantee the files were deleted once `rm` completes. See this <https://devblogs.microsoft.com/oldnewthing/20120907-00/?p=6663>. Occasionally, the tests are failing locally on my PC because of that (maybe 1 out of 50 times).





Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64301/new/

https://reviews.llvm.org/D64301