[PATCH] D63773: [clangd] dummy variable extraction on a function scope
Shaurya Gupta via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Jul 9 03:13:09 PDT 2019
SureYeaah added inline comments.
================
Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:187
+ std::string ExtractedVarDecl = std::string("auto ") + VarName.str() + " = " +
+ ExtractionCode.str() + "; ";
+ return tooling::Replacement(SM, InsertionLoc, 0, ExtractedVarDecl);
----------------
sammccall wrote:
> nit: trailing space? should this be a newline?
Making it a newline makes writing tests harder.
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D63773/new/
https://reviews.llvm.org/D63773
More information about the cfe-commits
mailing list