[PATCH] D64257: [clangd] Added highlighting for non-builtin types

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 9 02:24:40 PDT 2019


sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/SemanticHighlightingTests.cpp:87
+      typedef abc::$Class[[A]]<int> AAA;
+      enum class $Enum[[E]] {};
+      enum $Enum[[EE]] {};
----------------
hokein wrote:
> could we split the enum case into a separate testcase? 
> 
> Thinking it further, we may want to highlight the enumerator as well.
(please don't add enum value highlighting in this patch, though)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64257/new/

https://reviews.llvm.org/D64257





More information about the cfe-commits mailing list