[PATCH] D64062: Remove both -dumpversion and __VERSION__

[Reid Kleckner via Phabricator via cfe-commits]

rnk added a comment.

In D64062#1567175 <https://reviews.llvm.org/D64062#1567175>, @sylvestre.ledru wrote:

> This isn't firefox per say but thirdparty apps.
>  If you feel confident, sure, we can land that and see what happens :)


One concern that I have is that we don't have a replacement for `-dumpversion`. I thought I saw someone propose adding such a flag, but I can't find it. Basically, we should do something to handle this user's use case:
http://clang-developers.42468.n3.nabble.com/How-to-dump-clang-version-td4025542.html



================
Comment at: docs/ReleaseNotes.rst:83
+
+- ``clang -dumpversion`` has been removed. It has been introduced for
+  old gcc compatibility purposes.
----------------
Maybe "It had been introduced..." or "It was introduced..." instead.

Actually, I think it's worth taking the time to elaborate a bit. Users *will* trip over this, and it's likely that the release notes will become the canonical documentation for it.

Try this text:
```
- The ``-dumpversion`` flag and the ``__VERSION__`` macro have been removed.
  Previously they both produced information designed for compatibility with GCC
  4.2.1, but that should no longer be necessary. To get clang's version, use the
  `clang namespaced version macros`_ and ``--version``.

_ https://clang.llvm.org/docs/LanguageExtensions.html#builtin-macros
```


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64062/new/

https://reviews.llvm.org/D64062