[PATCH] D64349: clang-cl: Port cl.exe's C4659 to clang-cl

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 8 16:31:11 PDT 2019


thakis added a comment.

Thanks!



================
Comment at: clang/test/Sema/pragma-section.c:57
+
+// Not sure if this should warn or not.
+__attribute__((section(".drectve"))) int drectve_int;
----------------
rnk wrote:
> I agree it probably shouldn't, I imagine mingw users will want to be able to use this kind of code pattern to interop between GCC and Clang:
>   __attribute__((section(".drective")))
>   const char LinkerFlags[] = "-export:foo -export:bar";
That's a nice argument, added as comment :)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64349/new/

https://reviews.llvm.org/D64349





More information about the cfe-commits mailing list