[PATCH] D63857: [clang-doc] Add a structured HTML generator

Diego Astiazarán via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 8 15:45:50 PDT 2019


DiegoAstiazaran added inline comments.


================
Comment at: clang-tools-extra/clang-doc/HTMLGenerator.cpp:75
+    Children.emplace_back(
+        llvm::make_unique<TextNode>(Text.str(), !InlineChildren));
+  }
----------------
jakehehrlich wrote:
> I think you can just write `Children.emplace_back(Text.str(), !InlineChildren)`
I think it is necessary to explicitly pass a unique_ptr, not only the args.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63857/new/

https://reviews.llvm.org/D63857





More information about the cfe-commits mailing list