[PATCH] D64151: Enhance abseil-faster-strsplit-delimiter to handle other non-printable characters.

[Xiaoyi Zhang via Phabricator via cfe-commits]

zhangxy988 marked an inline comment as done.
zhangxy988 added inline comments.


================
Comment at: clang-tools-extra/test/clang-tidy/abseil-faster-strsplit-delimiter.cpp:55
+
+  absl::StrSplit("ABC", R"(A)");
+  // CHECK-MESSAGES: [[@LINE-1]]:25: warning: absl::StrSplit() called with a string literal consisting of a single character; consider using the character overload [abseil-faster-strsplit-delimiter]
----------------
lebedev.ri wrote:
> Is there a negative test, `absl::StrSplit("ABC", R"(AA)");`?
> Also what about wide chars? (the second assertion)
I don't really know how to write a negative test like that.
This check is only concerned with single character string literal and it doesn't support wide char (since `StrSplit` doesn't).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64151/new/

https://reviews.llvm.org/D64151