[PATCH] D63846: [clang] Preserve names of addrspacecast'ed values.

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In D63846#1574311 <https://reviews.llvm.org/D63846#1574311>, @vzakhari wrote:

> In D63846#1574302 <https://reviews.llvm.org/D63846#1574302>, @rjmccall wrote:
>
> > I don't know what I think about widespread use of `-fno-discard-value-names` for now; please continue to use FileCheck variables, and we can make a holistic decision about that flag later.
>
>
> Sorry, I have one particular question about clang/test/CodeGenOpenCLCXX/addrspace-of-this.cl:
>  // Test the address space of 'this' when invoking copy-constructor.
>  // COMMON: [[C1GEN:%c1.ascast[0-9]*]] = addrspacecast %class.C* %c1 to %class.C addrspace(4)*
>
> This check seems to rely on %c1 name already.  I guess the matching may go off, if we do not use actual names on the right hand side of the assignment.  Should I do anything about the right hand side, or just use a generic wildcard on the left hand side?


I forgot that of course you're updating this test already.  If you can update the test to use variables without damaging the quality of the test, please do so.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63846/new/

https://reviews.llvm.org/D63846