[PATCH] D64169: ARM MTE stack sanitizer.

[Vitaly Buka via Phabricator via cfe-commits]

vitalybuka accepted this revision.
vitalybuka added inline comments.


================
Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:28
+  if (!CGM.getLangOpts().Sanitize.hasOneOf(
+          SanitizerKind::Address | SanitizerKind::KernelAddress |
+          SanitizerKind::HWAddress | SanitizerKind::KernelHWAddress |
----------------
maybe shared constant or function for :
SanitizerKind::Address | SanitizerKind::KernelAddress |
          SanitizerKind::HWAddress | SanitizerKind::KernelHWAddress |
          SanitizerKind::MemTag


================
Comment at: llvm/docs/BitCodeFormat.rst:1060
 * code 58: ``shadowcallstack``
+* code 62: ``sanitize_memtag``
 
----------------
why it's 62 and not e.g. 59?


================
Comment at: llvm/test/Bitcode/attributes.ll:363
+{
+        ret void;
+}
----------------
indentation is inconsistent


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64169/new/

https://reviews.llvm.org/D64169