[PATCH] D64239: [AArch64] Fix vsqadd scalar intrinsics operands

[John Brawn via Phabricator via cfe-commits]

john.brawn accepted this revision.
john.brawn added a comment.
This revision is now accepted and ready to land.

LGTM, with a couple of nitpicks.

> The existing unsigned argument can cause faulty code as float to unsigned conversion is undefined,
>  which llvm/clang optimizes away.

It's specifically negative float to unsigned that's undefined.



================
Comment at: test/CodeGen/aarch64-neon-vsqadd-float-conversion.c:2
+// RUN: %clang_cc1 -triple arm64-none-linux-gnu -target-feature +neon \
+// RUN:     -fallow-half-arguments-and-returns -S -disable-O0-optnone -emit-llvm -o - %s \
+// RUN: | opt -S -mem2reg -dce \
----------------
I don't think -fallow-half-arguments-and-returns is necessary.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64239/new/

https://reviews.llvm.org/D64239