[PATCH] D64127: [clangd] Deduplicate clang-tidy diagnostic messages.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/Diagnostics.cpp:427
   }
+  // Deduplicate clang-tidy diagnostics -- some clang-tidy checks may emit
+  // duplicated messages due to various reasons (e.g. the check doesn't handle
----------------
sammccall wrote:
> This sorting/partitioning seems a bit heavyweight... what about
> 
> ```
> DenseSet<pair<Range, Message>> SeenDiagnostics;
> llvm::erase_if([&](const Diag &D) {
>   return !SeenDiagnostics.try_emplace(D.Range, D.Message).second;
> });
> ```
This is neat. DenseSet requires a hashvalue function of the value, which we don't have, switched to use `set`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64127/new/

https://reviews.llvm.org/D64127