[PATCH] D62883: [analyzer] Track terminator conditions on which a tracked expressions depends

[Artem Dergachev via Phabricator via cfe-commits]

NoQ accepted this revision.
NoQ added a comment.

Accept².



================
Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1824-1825
+  // because of this, let's explain why we believe control reached this point.
+  // TODO: Shouldn't we track control dependencies of every bug location, rather
+  // than only tracked expressions?
+  if (LVState->getAnalysisManager().getAnalyzerOptions().ShouldTrackConditions)
----------------
To think: not sure you want to do this for memory leak reports, because the place where the leak is discovered (i.e., where we randomly decided to run garbage collection and noticed a leak) may be fairly weird. Path to that point may still be moderately interesting (after all, it presumably doesn't leak on other paths), but i'm still worried that we may bring in some completely unrelated stuff. I might be wrong.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62883/new/

https://reviews.llvm.org/D62883