[PATCH] D64119: [PowerPC] Support constraint code "ww"

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 3 20:02:26 PDT 2019


MaskRay marked an inline comment as done.
MaskRay added inline comments.


================
Comment at: llvm/test/CodeGen/PowerPC/inlineasm-vsx-reg.ll:42
+
+define float @test_ww(float %x, float %y) {
+  %1 = tail call float asm "xsmaxdp ${0:x}, ${1:x}, ${2:x}", "=^ww,^ww,^ww"(float %x, float %y)
----------------
jsji wrote:
> Maybe we should add another test for ws as well? The above test is actually for 'x' modifier?
I think it is incorrect if the 'x' modifier is not used, so we probably don't have to check the no-modifier case.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64119/new/

https://reviews.llvm.org/D64119





More information about the cfe-commits mailing list