[PATCH] D62611: [analyzer][Dominators] Add unittests
Gábor Horváth via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Jul 3 11:39:10 PDT 2019
xazax.hun accepted this revision.
xazax.hun added a comment.
This revision is now accepted and ready to land.
Looks good to me, some nits inline.
================
Comment at: clang/unittests/Analysis/CFGBuildResult.h:1
+//===- unittests/Analysis/CFGTest.cpp - CFG tests -------------------------===//
+//
----------------
Filename not updated?
================
Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:1
+//===- unittests/Analysis/CFGTest.cpp - CFG tests -------------------------===//
+//
----------------
Filename not updated?
================
Comment at: clang/unittests/Analysis/CFGDominatorTree.cpp:13
+#include "clang/Analysis/CFG.h"
+#include "clang/Tooling/Tooling.h"
+#include "gtest/gtest.h"
----------------
Do you need the Tooling header here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D62611/new/
https://reviews.llvm.org/D62611
More information about the cfe-commits
mailing list