[PATCH] D64067: [X86][PPC] Support -mlong-double-64

Andy Kaylor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jul 3 11:34:30 PDT 2019


andrew.w.kaylor added a comment.

In D64067#1568895 <https://reviews.llvm.org/D64067#1568895>, @hfinkel wrote:

> One thing to realize about these flags is that they're ABI-altering flags. If the user provides the flag to alter the platform defaults, this only works if the user also ensures that matches the ABI of the relevant system libraries that the compiler is using (e.g., because the user is explicitly linking with a suitable libc).


Right. That's what I was trying to figure out. Are we relying on the users of this option not to shoot themselves in the foot? It sounds like yes. I believe that's the way we handled it in icc also, but gcc and icc do a lot of sketchy things that we wouldn't want to do in clang. In this case I don't object to the sketchiness, just so everyone realizes that's what we're doing.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64067/new/

https://reviews.llvm.org/D64067





More information about the cfe-commits mailing list