[PATCH] D64018: [clangd] Store hash of command line in index shards.

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.


================
Comment at: clang-tools-extra/clangd/index/Serialization.cpp:531
+    for (llvm::StringRef C : Cmd.CommandLine)
+      Result.Cmd->CommandLine.emplace_back(C.str());
+  }
----------------
nit: push_back, or emplace_back(C)


================
Comment at: clang-tools-extra/clangd/index/Serialization.cpp:590
 
+  InternedCompileCommand Cmd;
+  if (Data.Cmd) {
----------------
nit: internedcmd to avoid confusion below?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64018/new/

https://reviews.llvm.org/D64018