[PATCH] D64073: [ASTImporter] Fix import of lambda in function param

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 15:56:25 PDT 2019


a_sidorin added a comment.

Hello Gabor,
There is an inline question about tests; other code looks fine.



================
Comment at: clang/lib/AST/ASTImporter.cpp:1713
+        // In case of lambdas, the class already has a definition ptr set, but
+        // the  contained decls are not imported yet. Also, isBeingDefined was
+        // set in CXXRecordDecl::CreateLambda.  We must import the contained
----------------
Two spaces after 'the'.


================
Comment at: clang/unittests/AST/ASTImporterTest.cpp:5103
+  // count.
+  for (auto &D : ToL->decls()) {
+    (void)D;
----------------
Can we use std::distance instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64073/new/

https://reviews.llvm.org/D64073





More information about the cfe-commits mailing list