[PATCH] D63915: [analyzer] ReturnValueChecker: Model the guaranteed boolean return value of function calls

[Artem Dergachev via Phabricator via cfe-commits]

NoQ added inline comments.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp:86
+  std::string Name = "";
+  Name += dyn_cast<CXXMethodDecl>(Call.getDecl())->getParent()->getName();
+  Name += "::";
----------------
Either `cast<>` or check for null.


================
Comment at: clang/lib/StaticAnalyzer/Checkers/ReturnValueChecker.cpp:116
+
+        BR.markInteresting(SFC);
+
----------------
This isn't the stack frame i was talking about, but if you move this code to `checkEndFunction` it will be.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D63915/new/

https://reviews.llvm.org/D63915