[PATCH] D64087: [clang] Correct source locations for instantiations of out-of-line defaulted special member functions. (PR25683)

Tom Honermann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 2 10:24:32 PDT 2019


tahonermann added a comment.

See PR25683 (https://bugs.llvm.org/show_bug.cgi?id=25683) for more details.  The patch posted here differs slightly from what is posted in the PR; `getLocation()` is called instead of `getBeginLoc()` since the latter may return a customized begin location.

I believe the impact to the two tests is a desirable change; the instantiation note seems like it should be correlated with the definition, not the declaration.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D64087/new/

https://reviews.llvm.org/D64087





More information about the cfe-commits mailing list